Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/307 activity pulp paper #2153

Merged
merged 13 commits into from
Sep 23, 2024
Merged

Conversation

joshgamache
Copy link
Contributor

Addresses bcgov/cas-reporting#307. This adds the Pulp and Paper production activity.

Changes 🚧

  • Adds backend config/migration for Pulp and Paper production activity.
  • Adds frontend page and components for Pulp and Paper production activity.

To test 🔬

  • make reset_db to apply latest migrations.
  • spin up the front, backend and postgres.
  • Login, then navigate to http://localhost:3000/reporting/reports/1/facilities/1/activities/pulp_and_paper_production, click through the available form fields.
    • The Gas type dropdown options should change options available in the methodology field.
    • The Methodology dropdown options spawn additional fields, depending on the option selected.

@joshgamache joshgamache self-assigned this Sep 4, 2024
@joshgamache joshgamache force-pushed the feat/307-activity-pulp-paper branch 3 times, most recently from 68e6cc3 to e2e0286 Compare September 6, 2024 20:32
Copy link
Contributor

@dleard dleard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh! A few changes requested around the structure of the form to match the rules in the excel spreadsheet. Let me know if you have questions :)

Copy link
Contributor

@dleard dleard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great wwork! I tested it & it's all working as expected. Looks good on my end, but because this one became a bit of a special case let's get a design review on this one too.

@joshgamache joshgamache force-pushed the feat/307-activity-pulp-paper branch 2 times, most recently from f6e5042 to 8454c26 Compare September 23, 2024 19:39
@joshgamache joshgamache merged commit bd5189a into develop Sep 23, 2024
43 checks passed
@joshgamache joshgamache deleted the feat/307-activity-pulp-paper branch September 23, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants