-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/307 activity pulp paper #2153
Conversation
68e6cc3
to
e2e0286
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Josh! A few changes requested around the structure of the form to match the rules in the excel spreadsheet. Let me know if you have questions :)
bciers/apps/reporting/src/app/components/activities/pulpAndPaperProduction.tsx
Outdated
Show resolved
Hide resolved
bc_obps/reporting/json_schemas/2024/pulp_and_paper_production/pulp_and_paper_production.json
Outdated
Show resolved
Hide resolved
bc_obps/reporting/json_schemas/2024/pulp_and_paper_production/pulp_and_paper_production.json
Outdated
Show resolved
Hide resolved
bciers/apps/reporting/src/app/components/activities/uiSchemas/pulpAndPaperUiSchema.ts
Outdated
Show resolved
Hide resolved
bciers/apps/reporting/src/app/components/activities/uiSchemas/pulpAndPaperUiSchema.ts
Outdated
Show resolved
Hide resolved
bciers/apps/reporting/src/app/components/activities/uiSchemas/pulpAndPaperUiSchema.ts
Outdated
Show resolved
Hide resolved
bciers/apps/reporting/src/app/components/activities/uiSchemas/pulpAndPaperUiSchema.ts
Outdated
Show resolved
Hide resolved
bciers/apps/reporting/src/app/components/activities/uiSchemas/pulpAndPaperUiSchema.ts
Outdated
Show resolved
Hide resolved
bciers/apps/reporting/src/app/components/activities/uiSchemas/pulpAndPaperUiSchema.ts
Outdated
Show resolved
Hide resolved
bciers/apps/reporting/src/app/components/activities/uiSchemas/pulpAndPaperUiSchema.ts
Outdated
Show resolved
Hide resolved
e2e0286
to
46fcf40
Compare
46fcf40
to
dee7f7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great wwork! I tested it & it's all working as expected. Looks good on my end, but because this one became a bit of a special case let's get a design review on this one too.
f6e5042
to
8454c26
Compare
bca6969
to
0695f60
Compare
Addresses bcgov/cas-reporting#307. This adds the Pulp and Paper production activity.
Changes 🚧
To test 🔬
make reset_db
to apply latest migrations.http://localhost:3000/reporting/reports/1/facilities/1/activities/pulp_and_paper_production
, click through the available form fields.Gas type
dropdown options should change options available in the methodology field.Methodology
dropdown options spawn additional fields, depending on the option selected.